[PATCH] i2c: efm32: fix a failure path in efm32_i2c_probe()

From	Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups	linux.kernel
Subject	[PATCH] i2c: efm32: fix a failure path in efm32_i2c_probe()
Date	2016-07-16 01:40 +0200
Message-ID	<rVkS5-4J0-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There is the only failure path in efm32_i2c_probe(),
where clk_disable_unprepare() is missed.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/i2c/busses/i2c-efm32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
index 8eff62738877..e253598d764c 100644
--- a/drivers/i2c/busses/i2c-efm32.c
+++ b/drivers/i2c/busses/i2c-efm32.c
@@ -433,7 +433,7 @@ static int efm32_i2c_probe(struct platform_device *pdev)
 	ret = request_irq(ddata->irq, efm32_i2c_irq, 0, DRIVER_NAME, ddata);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to request irq (%d)\n", ret);
-		return ret;
+		goto err_disable_clk;
 	}
 
 	ret = i2c_add_adapter(&ddata->adapter);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: efm32: fix a failure path in efm32_i2c_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-07-16 01:40 +0200
  Re: [PATCH] i2c: efm32: fix a failure path in efm32_i2c_probe() Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-07-16 11:00 +0200
  Re: [PATCH] i2c: efm32: fix a failure path in efm32_i2c_probe() Wolfram Sang <wsa@the-dreams.de> - 2016-07-19 06:30 +0200

csiph-web