Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg
Date	2016-07-16 00:10 +0200
Message-ID	<rVjt0-40D-17@gated-at.bofh.it> (permalink)
References	(4 earlier) <rV6Fr-4zR-13@gated-at.bofh.it> <rV6P8-4CX-29@gated-at.bofh.it> <rV7rQ-55C-27@gated-at.bofh.it> <rV7Lc-5c0-21@gated-at.bofh.it> <rV7Lc-5c0-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Krzysztof and Jacek,

Thanks for the review.

On 07/15/2016 03:37 AM, Jacek Anaszewski wrote:
> On 07/15/2016 11:30 AM, Krzysztof Kozlowski wrote:
>> On 07/15/2016 11:18 AM, Jacek Anaszewski wrote:
>>> On 07/15/2016 10:33 AM, Krzysztof Kozlowski wrote:
>>>> On 07/15/2016 10:28 AM, Jacek Anaszewski wrote:
>>>>> On 07/15/2016 10:17 AM, Krzysztof Kozlowski wrote:
>>>>>> On 07/15/2016 10:14 AM, Jacek Anaszewski wrote:
>>>>>>>> However if these compatibles are exactly equal then
>>>>>>>> only one should be preferred. It makes everything easier. Second
>>>>>>>> can be
>>>>>>>> still documented e.g. as deprecated.
>>>>>>>
>>>>>>> Still, both of them are present in the driver. Shouldn't it be
>>>>>>> reflected
>>>>>>> in the documentation?
>>>>>>
>>>>>> Right, it is a good practice, so how about:
>>>>>>
>>>>>>      - compatible    : should be one of:
>>>>>>              "samsung,s5pv210-jpeg", "samsung,exynos3250-jpeg",
>>>>>>              "samsung,exynos4210-jpeg", "samsung,exynos5420-jpeg",
>>>>>>              "samsung,exynos5433-jpeg";
>>>>>>
>>>>>>              Deprecated: "samsung,exynos4212-jpeg"
>>>>>>
>>>>>> (or any other formatting)
>>>>>> plus update to DTS changing it to 4210?

I am sending the v2 doc patch that adds samsung,exynos4212-jpeg as
deprecated to begin with.

thanks,
-- Shuah

Thread

[PATCH] media: Doc add missing documentation for samsung,exynos4212-jpeg Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-14 22:10 +0200
  Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-15 08:30 +0200
  Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-15 09:30 +0200
    Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-15 10:20 +0200
      Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-15 10:30 +0200
        Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-15 10:40 +0200
          Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-15 11:20 +0200
            Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-15 11:40 +0200
              Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-16 00:10 +0200
            Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-07-15 11:40 +0200
    Re: [PATCH] media: Doc add missing documentation for  samsung,exynos4212-jpeg Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-15 10:20 +0200

csiph-web