Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit

From	Steve Longerbeam <slongerbeam@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit
Date	2016-07-16 00:40 +0200
Message-ID	<rVjW1-4an-1@gated-at.bofh.it> (permalink)
References	<rSqAF-51z-3@gated-at.bofh.it> <rSqAG-51z-21@gated-at.bofh.it> <rTwXn-7WS-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/10/2016 05:02 PM, Paul Gortmaker wrote:
>
> +#include <linux/export.h>
> +#include <linux/module.h>
> You have a u32 field in a struct called "modules" but aside from that, I do not
> see anything in this code requiring module.h -- did I miss something?
>
> You might want export.h for EXPORT_SYMBOL though.
>
>

Hi Paul, yes module.h wasn't needed. Fixed in next version.

Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-11 02:10 +0200
  Re: [PATCH 01/16] gpu: ipu-v3: Add Video Deinterlacer unit Steve Longerbeam <slongerbeam@gmail.com> - 2016-07-16 00:40 +0200

csiph-web