Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444569
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. |
| Date | 2016-07-15 23:00 +0200 |
| Message-ID | <rVing-38N-21@gated-at.bofh.it> (permalink) |
| References | <rRwRQ-2bm-5@gated-at.bofh.it> <rUNWa-1dc-25@gated-at.bofh.it> <rUXiN-76a-1@gated-at.bofh.it> <rVgEO-2iR-25@gated-at.bofh.it> <rVgEO-2iR-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 15 Jul 2016 13:00:40 -0600 Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
>
> ...
>
> In looking at this more, I agree that your patch fixes this particular bug,
> but I think that ultimately we might want something more general.
>
> ...
>
> --- a/include/linux/radix-tree.h
> +++ b/include/linux/radix-tree.h
> @@ -463,6 +463,9 @@ static inline struct radix_tree_node *entry_to_node(void *ptr)
> static __always_inline void **
> radix_tree_next_slot(void **slot, struct radix_tree_iter *iter, unsigned flags)
> {
> + if (unlikely(!slot))
> + return NULL;
> +
> if (flags & RADIX_TREE_ITER_TAGGED) {
> void *canon = slot;
I'll hang onto Andrey's
radix-tree-fix-radix_tree_iter_retry-for-tagged-iterators.patch for
now, plan to send it in to Linus Wednesdayish. If we can get the above
settled down prior to that then I shall swap over.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-07-15 00:30 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-07-15 21:10 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Andrew Morton <akpm@linux-foundation.org> - 2016-07-15 23:00 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-07-19 01:20 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Konstantin Khlebnikov <koct9i@gmail.com> - 2016-07-16 15:50 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Konstantin Khlebnikov <koct9i@gmail.com> - 2016-07-17 20:00 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-07-19 06:30 +0200
Re: [PATCH] radix-tree: fix radix_tree_iter_retry() for tagged iterators. Konstantin Khlebnikov <koct9i@gmail.com> - 2016-07-19 11:10 +0200
csiph-web