Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444518

Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling of_parse_phandle

Show all headers | View raw

On Fri 15 Jul 02:38 PDT 2016, Peter Chen wrote:

> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
> 
> Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  drivers/mfd/qcom_rpm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 2e44323..ecca115 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -538,6 +538,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  	}
>  
>  	rpm->ipc_regmap = syscon_node_to_regmap(syscon_np);
> +	of_node_put(syscon_np);
>  	if (IS_ERR(rpm->ipc_regmap))
>  		return PTR_ERR(rpm->ipc_regmap);
>  
> -- 
> 1.9.1
> 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] mfd: qcom_rpm: add missing of_node_put after calling  of_parse_phandle Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-15 21:00 +0200

csiph-web