Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] perf script python: Fix string vs byte array resolving
Date	2016-07-15 18:40 +0200
Message-ID	<rVejE-K7-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <rV5T3-43Z-7@gated-at.bofh.it> <rVdQB-zG-23@gated-at.bofh.it> <rVdQB-zG-21@gated-at.bofh.it> <rVe0h-D2-9@gated-at.bofh.it> <rVejE-K7-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Jul 15, 2016 at 01:37:31PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jul 15, 2016 at 06:13:10PM +0200, Jiri Olsa escreveu:
> > On Fri, Jul 15, 2016 at 12:02:31PM -0400, Steven Rostedt wrote:
> > 
> > SNIP
> > 
> > > > for "AA\1\0" this returns "1" although that should return "0".
> > > > 
> > > > orig len 4
> > > > decremented len 3
> > > > for:
> > > > 0 1
> > > > 
> > > > index 2 would not be inspected. Or am I missing something?
> > > > 
> > > > I think that the for check should be "i < len"
> > > 
> > > Yes it should be. I think we got the two solutions mixed up.
> > > 
> > > With the above len--, it should be i < len, but when we did the check
> > > for zero at the end, we needed the i < len - 1
> > 
> > ugh right.. should be 'i < len' check in the for loop,
> > 
> > there's also the patch 2/3 that needs to be changed
> > 
> > Arnaldo,
> > please let me know if you need me to resend this.
> 
> So I need to drop those, even with Rostedt's acked-by? Ok, please
> resend, hopefully this time with a Tested-by from the reporter?

I removed the first two, as the second needs context from the first,
kept the third one, so please resend just the first two.

- Arnaldo

Thread

[PATCH 1/3] perf script python: Fix string vs byte array resolving Jiri Olsa <jolsa@kernel.org> - 2016-07-15 09:40 +0200
  Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-15 09:40 +0200
  Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-15 17:40 +0200
  Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-15 18:10 +0200
    Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-15 18:20 +0200
      Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-15 18:40 +0200
      Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-15 18:40 +0200
      Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-15 19:20 +0200
  Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-15 19:20 +0200
    Re: [PATCH 1/3] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-16 18:00 +0200

csiph-web