Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2

From	Andrey Pronin <apronin@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2
Date	2016-07-15 19:00 +0200
Message-ID	<rVeCZ-QX-3@gated-at.bofh.it> (permalink)
References	<rV0A1-xW-3@gated-at.bofh.it> <rV0A1-xW-1@gated-at.bofh.it> <rV1Z7-1DV-5@gated-at.bofh.it> <rV28N-1GW-15@gated-at.bofh.it> <rV28N-1GW-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 14, 2016 at 09:34:39PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 14, 2016 at 08:32:01PM -0700, Andrey Pronin wrote:
> 
> > tpm2 shares some of the attributes with tpm1 (e.g. timeouts). Do I still
> > just add those separately for tpm2 to groups[1] and keep groups[0] empty?

Just realized that if we keep tpm_add_legacy_sysfs() intact, it doesn't
create symlinks for tpm2 case for any of the groups, including groups[0].
So, in tpm_sysfs_add_device() can just do smth like:

if (chip->flags & TPM_CHIP_FLAG_TPM2)
	chip->groups[chip->groups_cnt++] = &tpm2_dev_group;
else
	chip->groups[chip->groups_cnt++] = &tpm_dev_group;

Is that acceptable? Will submit the next version along those lines.

> 
> I think so. Since the file never exists for tpm2, nothing coded for
> tpm2 will ever look in the old location.
> 

There can be a common code working with tpm1.2 that will just continue
working with tpm2 if the common attributes are in the same place. So, some
part of code can be re-used as is, but I agree that there are not too
many common attributes. Will drop for now. Can be addressed later if
the clear need arises.

Thread

[PATCH 1/2] tpm: add sysfs attributes for tpm2 Andrey Pronin <apronin@chromium.org> - 2016-07-15 04:00 +0200
  Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-15 05:30 +0200
    Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-15 05:40 +0200
      Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Andrey Pronin <apronin@chromium.org> - 2016-07-15 19:00 +0200
        Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-15 19:10 +0200
    Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Andrey Pronin <apronin@chromium.org> - 2016-07-15 05:40 +0200
  Re: [PATCH 1/2] tpm: add sysfs attributes for tpm2 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-07-18 21:20 +0200

csiph-web