Re: [PATCH v3 08/12] irqchip: add J-Core AIC driver

From	Rich Felker <dalias@libc.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 08/12] irqchip: add J-Core AIC driver
Date	2016-07-15 17:50 +0200
Message-ID	<rVdxg-dW-29@gated-at.bofh.it> (permalink)
References	<rCzRD-5z7-3@gated-at.bofh.it> <rCzRE-5z7-27@gated-at.bofh.it> <rVdnA-ap-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 15, 2016 at 11:35:55AM -0400, Paul Gortmaker wrote:
> > +++ b/drivers/irqchip/irq-jcore-aic.c
> > @@ -0,0 +1,95 @@
> > +/*
> > + * J-Core SoC AIC driver
> > + *
> > + * Copyright (C) 2015-2016 Smart Energy Instruments, Inc.
> > + *
> > + * This file is subject to the terms and conditions of the GNU General Public
> > + * License.  See the file "COPYING" in the main directory of this archive
> > + * for more details.
> > + */
> > +
> > +#include <linux/irq.h>
> > +#include <linux/io.h>
> > +#include <linux/irqchip.h>
> > +#include <linux/irqdomain.h>
> > +#include <linux/module.h>
> 
> Please don't use module.h or MODULE_* in code that is controlled by
> a bool Kconfig.

Thanks for catching this. Fixed.

Rich

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 08/12] irqchip: add J-Core AIC driver Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-15 17:40 +0200
  Re: [PATCH v3 08/12] irqchip: add J-Core AIC driver Rich Felker <dalias@libc.org> - 2016-07-15 17:50 +0200

csiph-web