Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444364
| From | Benjamin Poirier <benjamin.poirier@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) |
| Date | 2016-07-15 17:20 +0200 |
| Message-ID | <rVd4e-8vN-17@gated-at.bofh.it> (permalink) |
| References | <rUID8-614-17@gated-at.bofh.it> <rV3xU-2IL-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On 2016/07/15 08:00, Leon Romanovsky wrote:
> On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote:
> > This is a driver for the ENA family of networking devices.
> >
> > Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
> > ---
> >
> > Notes:
>
> ...
>
> > - Increase driver version to 1.0.2
>
> ...
>
> > +static void ena_get_drvinfo(struct net_device *dev,
> > + struct ethtool_drvinfo *info)
> > +{
> > + struct ena_adapter *adapter = netdev_priv(dev);
> > +
> > + strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
> > + strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
>
> Does module version give anything valuable in real life usage?
> Do you plan to bump version after every patch?
>
> Hint, NO.
>
[...]
> > +
> > +#define DRV_MODULE_VER_MAJOR 1
> > +#define DRV_MODULE_VER_MINOR 0
> > +#define DRV_MODULE_VER_SUBMINOR 1
> > +
> > +#define DRV_MODULE_NAME "ena"
> > +#ifndef DRV_MODULE_VERSION
> > +#define DRV_MODULE_VERSION \
> > + __stringify(DRV_MODULE_VER_MAJOR) "." \
> > + __stringify(DRV_MODULE_VER_MINOR) "." \
> > + __stringify(DRV_MODULE_VER_SUBMINOR)
> > +#endif
> > +#define DRV_MODULE_RELDATE "22-JUNE-2016"
>
> Please remove it, driver version is useless in real life kernel usage.
>
The release date might be a bit overkill but the driver version is
useful in the context of distribution kernels where users sometimes mix
and match newer drivers (ex: the intel sf.net drivers) with older
kernels. When a bug is reported, a quick look at the module version can
help indicate the provenance of the driver.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Leon Romanovsky <leon@kernel.org> - 2016-07-15 07:10 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Benjamin Poirier <benjamin.poirier@gmail.com> - 2016-07-15 17:20 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Leon Romanovsky <leon@kernel.org> - 2016-07-15 17:50 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal <netanel@annapurnalabs.com> - 2016-07-19 13:10 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Leon Romanovsky <leon@kernel.org> - 2016-07-19 19:30 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Joe Perches <joe@perches.com> - 2016-07-19 20:00 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Leon Romanovsky <leon@kernel.org> - 2016-07-25 07:10 +0200
Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA) Netanel Belgazal <netanel@annapurnalabs.com> - 2016-07-19 20:40 +0200
csiph-web