Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444306
| From | Mel Gorman <mgorman@techsingularity.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix |
| Date | 2016-07-15 15:20 +0200 |
| Message-ID | <rVbc5-7mF-1@gated-at.bofh.it> (permalink) |
| References | <rVb2q-7js-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The patch "mm, vmscan: make shrink_node decisions more node-centric"
checks whether compaction is suitable on empty nodes. This is expensive
rather than wrong but is worth fixing.
This is a fix to the mmotm patch
mm-vmscan-make-shrink_node-decisions-more-node-centric.patch
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
mm/vmscan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 864a3b1e5f8b..4fdb9e419588 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2408,6 +2408,8 @@ static inline bool should_continue_reclaim(struct pglist_data *pgdat,
/* If compaction would go ahead or the allocation would succeed, stop */
for (z = 0; z <= sc->reclaim_idx; z++) {
struct zone *zone = &pgdat->node_zones[z];
+ if (!populated_zone(zone))
+ continue;
switch (compaction_suitable(zone, sc->order, 0, sc->reclaim_idx)) {
case COMPACT_PARTIAL:
--
2.6.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] Follow-up fixes to node-lru series v2 Mel Gorman <mgorman@techsingularity.net> - 2016-07-15 15:10 +0200
[PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix Mel Gorman <mgorman@techsingularity.net> - 2016-07-15 15:20 +0200
Re: [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix Minchan Kim <minchan@kernel.org> - 2016-07-15 17:50 +0200
Re: [PATCH 1/5] mm, vmscan: make shrink_node decisions more node-centric -fix Johannes Weiner <hannes@cmpxchg.org> - 2016-07-18 18:20 +0200
[PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Mel Gorman <mgorman@techsingularity.net> - 2016-07-15 15:20 +0200
Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Minchan Kim <minchan@kernel.org> - 2016-07-15 16:50 +0200
Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Mel Gorman <mgorman@techsingularity.net> - 2016-07-15 17:10 +0200
Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg Minchan Kim <minchan@kernel.org> - 2016-07-15 18:00 +0200
csiph-web