Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444295
| From | sunil.kovvuri@gmail.com |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 12/15] net: thunderx: Use skb_add_rx_frag() for split buffer Rx pkts |
| Date | 2016-07-15 15:10 +0200 |
| Message-ID | <rVb2r-7js-27@gated-at.bofh.it> (permalink) |
| References | <rVaSK-70X-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Sunil Goutham <sgoutham@cavium.com>
Instead of a round about way of converting buffers to SKBs and
combining them into a frag list, use standard skb_add_rx_frag()
API to merge page fragments. This code is useful when incoming
packets are of size more than RCV_FRAG_LEN which is currently
set to 2048bytes.
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 24 ++++++----------------
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
index ca223aa..ed2fe72 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
@@ -1184,8 +1184,8 @@ struct sk_buff *nicvf_get_rcv_skb(struct nicvf *nic, struct cqe_rx_t *cqe_rx)
int frag;
int payload_len = 0;
struct sk_buff *skb = NULL;
- struct sk_buff *skb_frag = NULL;
- struct sk_buff *prev_frag = NULL;
+ struct page *page;
+ int offset;
u16 *rb_lens = NULL;
u64 *rb_ptrs = NULL;
@@ -1218,22 +1218,10 @@ struct sk_buff *nicvf_get_rcv_skb(struct nicvf *nic, struct cqe_rx_t *cqe_rx)
skb_put(skb, payload_len);
} else {
/* Add fragments */
- skb_frag = nicvf_rb_ptr_to_skb(nic, *rb_ptrs,
- payload_len);
- if (!skb_frag) {
- dev_kfree_skb(skb);
- return NULL;
- }
-
- if (!skb_shinfo(skb)->frag_list)
- skb_shinfo(skb)->frag_list = skb_frag;
- else
- prev_frag->next = skb_frag;
-
- prev_frag = skb_frag;
- skb->len += payload_len;
- skb->data_len += payload_len;
- skb_frag->len = payload_len;
+ page = virt_to_page(phys_to_virt(*rb_ptrs));
+ offset = phys_to_virt(*rb_ptrs) - page_address(page);
+ skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, page,
+ offset, payload_len, RCV_FRAG_LEN);
}
/* Next buffer pointer */
rb_ptrs++;
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/15] net: thunderx: Add support for 81xx and 83xx sunil.kovvuri@gmail.com - 2016-07-15 15:00 +0200 [PATCH v3 05/15] net: thunderx: Enable CQE_RX desc's extension fields sunil.kovvuri@gmail.com - 2016-07-15 15:00 +0200 [PATCH v3 07/15] net: thunderx: Support for different LMAC types within BGX sunil.kovvuri@gmail.com - 2016-07-15 15:00 +0200 [PATCH v3 10/15] net: thunderx: Add RGMII interface type support sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 15/15] net: thunderx: Don't set mac address for secondary Qset VFs sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 06/15] net: thunderx: Enable mailbox interrupts on 81xx/83xx sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 12/15] net: thunderx: Use skb_add_rx_frag() for split buffer Rx pkts sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 08/15] net: thunderx: Add 81xx support to BGX driver sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 13/15] net: thunderx: Improvement for MBX interface debug messages sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 03/15] net: thunderx: Add support for 81xx and 83xx chips sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 11/15] net: thunderx: Use netdev's name for naming VF's interrupts sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 [PATCH v3 14/15] net: thunderx: Reset RXQ HW stats when interface is brought down sunil.kovvuri@gmail.com - 2016-07-15 15:10 +0200 Re: [PATCH v3 00/15] net: thunderx: Add support for 81xx and 83xx Sunil Kovvuri <sunil.kovvuri@gmail.com> - 2016-07-21 08:00 +0200
csiph-web