Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial_info function arguments

From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial_info function arguments
Date	2016-07-15 14:10 +0200
Message-ID	<rVa6m-6K7-23@gated-at.bofh.it> (permalink)
References	<rxUDo-21y-3@gated-at.bofh.it> <rxUDr-21y-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 12, 2016 at 10:48:54AM +0200, Mathieu OTHACEHE wrote:
> It is sufficient to pass usb_serial_port structure to ti_get_serial_info
> and ti_set_serial_info.
> 
> Also move functions above ioctl to avoid function prototyping
> and use unsigned int instead of unsigned for cwait variable.

Avoid changing things in the same patch as you move something, if moving
is at all needed.

Thanks,
Johan

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 22/36] usb: serial: ti_usb_3410_5052: Change  ti_get/set_serial_info function arguments Johan Hovold <johan@kernel.org> - 2016-07-15 14:10 +0200

csiph-web