Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444898

Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on compound page arrival"

Show all headers | View raw

On Sat, 16 Jul 2016, Jens Rottmann wrote:

> Hi Minchan (& all),
> 
> Minchan Kim wrote:
> > [...] found __lru_cache_add has a bug. [...]
> [-]     if (!pagevec_space(pvec) || PageCompound(page))
> [+]     if (!pagevec_add(pvec, page) || PageCompound(page))
> 
> Confirm that did plug the leak, thanks!
> 
> Also I just saw this was known already:
> https://marc.info/?l=linux-kernel&m=146858368215856
> Sorry for not noticing earlier, I did search for "4.1.28 memory leak", but not for "memleak".
> 
> Many thanks,
> Jens

For me it fixed the bug too.

Mikulas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on  compound page arrival" Minchan Kim <minchan@kernel.org> - 2016-07-16 16:50 +0200
  Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on  compound page arrival" Jens Rottmann <jens.rottmann@adlinktech.com> - 2016-07-16 19:40 +0200
    Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs  on compound page arrival" Mikulas Patocka <mpatocka@redhat.com> - 2016-07-16 20:50 +0200
  Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on  compound page arrival" Michal Hocko <mhocko@kernel.org> - 2016-07-18 09:00 +0200

csiph-web