[patch] MIPS: RM7000: Double locking bug in rm7k_tc_disable()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] MIPS: RM7000: Double locking bug in rm7k_tc_disable()
Date	2016-07-15 13:20 +0200
Message-ID	<rV9jX-6dN-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We obviously intended to enable IRQs again at the end.

Fixes: 745aef5df1e2 ('MIPS: RM7000: Add support for tertiary cache')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/mips/mm/sc-rm7k.c b/arch/mips/mm/sc-rm7k.c
index 9ac1efc..78f900c 100644
--- a/arch/mips/mm/sc-rm7k.c
+++ b/arch/mips/mm/sc-rm7k.c
@@ -161,7 +161,7 @@ static void rm7k_tc_disable(void)
 	local_irq_save(flags);
 	blast_rm7k_tcache();
 	clear_c0_config(RM7K_CONF_TE);
-	local_irq_save(flags);
+	local_irq_restore(flags);
 }
 
 static void rm7k_sc_disable(void)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[patch] MIPS: RM7000: Double locking bug in rm7k_tc_disable() Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-15 13:20 +0200

csiph-web