Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1444204
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments |
| Date | 2016-07-15 13:40 +0200 |
| Message-ID | <rV9Dk-6kq-9@gated-at.bofh.it> (permalink) |
| References | <rxUDo-21y-3@gated-at.bofh.it> <rxUN6-2vc-47@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 12, 2016 at 10:48:50AM +0200, Mathieu OTHACEHE wrote: > Remove useless ti_device pointer, and change addr to u32. > Move function upper to avoid function prototyping. That's just noise. Having an occasional prototype is just fine. You may want to consider reordering functions for the first submission, but no need to move things around after that. > Also change size variable in function from int to size_t. Combining changes with moving code, makes it harder to review for no good reason. Thanks, Johan
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments Johan Hovold <johan@kernel.org> - 2016-07-15 13:40 +0200
csiph-web