Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444084

Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver

Show all headers | View raw

Hi Arnd,

On 2016/7/15 16:41, Arnd Bergmann wrote:
> On Friday, July 15, 2016 4:26:32 PM CEST Dongpo Li wrote:
>> This patch set adds a Hisilicon MDIO bus driver and
>> a Fast Ethernet MAC(FEMAC) driver.
>> We also abstract a general interface "of_phy_get_and_connect"
>> for PHY connect. User will have no bother with getting
>> "phy-mode" and "phy-handle" any more.
>>
>> Changes in v1:
>> - Pass private data structure instead of struct mii_bus
>>   in MDIO read and write operation.
>> - Return the error which devm_clk_get() gives when MDIO probe.
>> - Leave the clock unprepared and disabled on error when MDIO probe.
>> - Abstract a general interface "of_phy_get_and_connect" for PHY connect.
>> - Remove the "_reset" suffixes in "reset-names" property.
>> - Enable tx per-packet interrupt when tx fifo full.
>> - Remove pointless compatible and add SoC specific compatible.
>> - Declare only one clock in MAC dts documentation.
>> - Add standard unit suffixes for "phy-reset-delays".
>> - Use a smaller NAPI poll weight 16 for our Fast Ethernet MAC.
>> - Use phy_ethtool_{get|set}_link_ksettings for ethtool ops.
>> - Use phydev from struct net_device in MAC driver.
>>
> 
> Looks all good to me now,
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> One comment on the submission format: we normally count the initial
> submission as "v1", so after [PATCH 0/3], the following version is
> [PATCH v2 0/3], not [PATCH v1 0/3].
> 
> No need to re-send for this now, and if you end up having to make
> other changes, just continue with "v2" for this driver, just follow
> the normal scheme if you send another driver.
> 
Okay, many thanks for your friendly reminder.   :)

> 	Arnd
> 
> .
> 

    Regards,
    Dongpo

.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver Dongpo Li <lidongpo@hisilicon.com> - 2016-07-15 10:40 +0200
  [PATCH v1 2/3] of_mdio: Abstract a general interface for phy connect Dongpo Li <lidongpo@hisilicon.com> - 2016-07-15 10:40 +0200
  [PATCH v1 3/3] net: hisilicon: Add Fast Ethernet MAC driver Dongpo Li <lidongpo@hisilicon.com> - 2016-07-15 10:40 +0200
  Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver Arnd Bergmann <arnd@arndb.de> - 2016-07-15 10:50 +0200
    Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver Dongpo Li <lidongpo@hisilicon.com> - 2016-07-15 11:10 +0200
  Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver David Miller <davem@davemloft.net> - 2016-07-17 06:50 +0200

csiph-web