Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444116

Re: [PATCH] ARM: tegra: fix erroneous address in dts

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 07/15/2016 12:02 AM, Thierry Reding wrote:
> On Thu, Jul 14, 2016 at 06:48:57PM +0200, Ralf Ramsauer wrote:
>> c90bb7b enabled the high speed UARTs of the Jetson TK1. The address
>> specification inside the dts is wrong. Fix it and use the correct
>> address.
>>
>> Fixes: c90bb7b9b9 ("ARM: tegra: Add high speed UARTs to Jetson TK1 device tree")
>> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
>> ---
>>  arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> These addresses are correct. The 0, prefix was dropped from the unit
> address in commit b5896f67ab3c ("ARM: tegra: Remove commas from unit
> addresses on Tegra124").
> 
> What's the problem that you're seeing? What's not working for you?
I cannot find b5896f67ab3c neither in swarren's tree nor in linux
upstream. But there's d0bc5aaf890 in swarren's linux-tegra tree that
matches your described changes and was committed on 1st of July. But
this patch is not upstream yet, while the other patch is.

Have a look at mainline tegra124-jetson-tk1.dts, there the addresses are
erroneous as they still use the 0, annotation. And I just realised, that
somehow, upstream patch c90bb7b slightly differs from my initial patch
[1] on the mailing list.

  Ralf

[1] http://permalink.gmane.org/gmane.linux.ports.tegra/24779
> 
> Thierry
> 

-- 
Ralf Ramsauer
PGP: 0x8F10049B

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: tegra: fix erroneous address in dts Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-07-14 19:00 +0200
  Re: [PATCH] ARM: tegra: fix erroneous address in dts Thierry Reding <thierry.reding@gmail.com> - 2016-07-15 00:10 +0200
    Re: [PATCH] ARM: tegra: fix erroneous address in dts Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-07-15 11:40 +0200
      Re: [PATCH] ARM: tegra: fix erroneous address in dts Stephen Warren <swarren@wwwdotorg.org> - 2016-07-15 18:10 +0200
        Re: [PATCH] ARM: tegra: fix erroneous address in dts Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-07-15 18:20 +0200
          Re: [PATCH] ARM: tegra: fix erroneous address in dts Thierry Reding <thierry.reding@gmail.com> - 2016-07-18 08:10 +0200
            Re: [PATCH] ARM: tegra: fix erroneous address in dts Ralf Ramsauer <ralf@ramses-pyramidenbau.de> - 2016-07-18 11:30 +0200

csiph-web