Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1444016

Re: [PATCH -next] mtd: nand: omap2: fix return value check in omap_nand_probe()

Show all headers | View raw

On Thu, 14 Jul 2016 09:05:39 -0700
Brian Norris <computersforpeace@gmail.com> wrote:

> On Thu, Jul 14, 2016 at 12:06:45PM +0000, weiyj_lk@163.com wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > 
> > In case of error, the function dma_request_chan() returns ERR_PTR() and
> > never returns NULL. The NULL test in the return value check should be
> > replaced with IS_ERR().
> > 
> > Fixes: aa7abd312c11 ('mtd: nand: omap2: Support parsing dma channel
> > information from DT')
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>  
> 
> Acked-by: Brian Norris <computersforpeace@gmail.com>
> 
> Boris,
> 
> The affected commit is in your pull request, which I might review/pull
> today. I'll just plan on applying this on top, unless you'd prefer to
> fixup and resend.

Nope, you can apply it directly on top of my pull request (unless you
find other things to fix and want me to send a v3).

Thanks,

Boris

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] mtd: nand: omap2: fix return value check in omap_nand_probe() weiyj_lk@163.com - 2016-07-14 14:10 +0200
  Re: [PATCH -next] mtd: nand: omap2: fix return value check in  omap_nand_probe() Brian Norris <computersforpeace@gmail.com> - 2016-07-14 18:10 +0200
    Re: [PATCH -next] mtd: nand: omap2: fix return value check in  omap_nand_probe() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-15 09:50 +0200
  Re: [PATCH -next] mtd: nand: omap2: fix return value check in  omap_nand_probe() Brian Norris <computersforpeace@gmail.com> - 2016-07-16 02:20 +0200

csiph-web