Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1443992

Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

From Peter Chen <hzpeterchen@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver
Date 2016-07-15 09:30 +0200
Message-ID <rV5Jn-40F-3@gated-at.bofh.it> (permalink)
References <rTDmb-3uz-35@gated-at.bofh.it> <rSTsZ-7c0-5@gated-at.bofh.it> <rTDmb-3uz-43@gated-at.bofh.it> <rU1ou-2tG-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote:
> > > +
> > > +err_clks:
> > > +	ci_hdrc_qoriq_disable_unprepare_clks(pdev);
> > 
> > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation.
> > 
> 
> We do have multiple clocks, but currently one is integrated in code. Hence created 
> the APIs for future use. 

If you could not integrate one more clocks, I suggest not creating dedicated
API until you need in future.

-- 

Best Regards,
Peter Chen

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Peter Chen <hzpeterchen@gmail.com> - 2016-07-11 09:00 +0200
  RE: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Rajesh Bhagat <rajesh.bhagat@nxp.com> - 2016-07-12 10:40 +0200
    Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Peter Chen <hzpeterchen@gmail.com> - 2016-07-15 09:30 +0200
      RE: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Rajesh Bhagat <rajesh.bhagat@nxp.com> - 2016-07-15 13:50 +0200

csiph-web