RE: [PATCH 08/32] Define CONFIG_INTEL_RDT

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	RE: [PATCH 08/32] Define CONFIG_INTEL_RDT
Date	2016-07-13 23:20 +0200
Message-ID	<rUzJx-7e-53@gated-at.bofh.it> (permalink)
References	<rUe2l-2xx-3@gated-at.bofh.it> <rUe2o-2xx-89@gated-at.bofh.it> <rUpAw-1Nt-91@gated-at.bofh.it> <rUwLE-6Du-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 13 Jul 2016, Yu, Fenghua wrote:
> Here is why this patch behaves like this:
> 
> This patch and actually first 12 patches are directly from last year's
> cgroup base CAT patch series. The last year's patch series had gone 16
> versions already. Because the first 12 patches have been reviewed many
> times, we keep them untouched (except removing cgroup code in patch 8 and
> some unused cdp code in patch 11) and release other patches on top of the
> first 12 patches.

Which is not making the review any simpler. In order to understand the
modifications I have to go back and page in the original stuff from last year
once again. So I have to read the original patch first to understand the
modifications and then get the overall picture of the new stuff. Please fold
stuff back to the proper places so I can start reviewing this thing under the
new design idea instead of twisting my brain around two designs.

> I fully agree this patch should be split if we want to have a good overall
> patch series.

Good.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 08/32] Define CONFIG_INTEL_RDT "Fenghua Yu" <fenghua.yu@intel.com> - 2016-07-13 00:10 +0200
  Re: [PATCH 08/32] Define CONFIG_INTEL_RDT Thomas Gleixner <tglx@linutronix.de> - 2016-07-13 12:30 +0200
    RE: [PATCH 08/32] Define CONFIG_INTEL_RDT "Yu, Fenghua" <fenghua.yu@intel.com> - 2016-07-13 20:10 +0200
      RE: [PATCH 08/32] Define CONFIG_INTEL_RDT "Yu, Fenghua" <fenghua.yu@intel.com> - 2016-07-13 23:20 +0200
      RE: [PATCH 08/32] Define CONFIG_INTEL_RDT Thomas Gleixner <tglx@linutronix.de> - 2016-07-13 23:20 +0200

csiph-web