Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation

From	"Rafael J. Wysocki" <rafael@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation
Date	2016-07-13 22:10 +0200
Message-ID	<rUyDM-7RI-31@gated-at.bofh.it> (permalink)
References	(1 earlier) <rUp7s-1hq-17@gated-at.bofh.it> <rUpqN-1JD-5@gated-at.bofh.it> <rUpAv-1Nt-61@gated-at.bofh.it> <rUpKa-1QV-25@gated-at.bofh.it> <rUvPz-5Zr-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 13, 2016 at 7:01 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> >>and then swapon the swap device, and do a testing. This should be safer?
>> >Yeah, that's the way. Read-only root is other option.
>> >
>> >>>I guess updating documentation would be welcome from my side,
>> >>>otherwise it should be ok.
>> >>OK, I'll  update the documents.
>> >Just add fat warning into the documentation.
>> OK.
>
> Actually... If you could add
>
> printk(KERN_ALERT "Hibernation image written. If you have any
> filesystems mounted read-write and attempt to resume, you'll corrupt
> your data. To prevent that, remove the hibernation image.\n")
>
> ...I guess that would save someone's filesystem. (Yes, very high
> loglevel. If you attempt to do this from anything else then singleuser
> or initrd, you are asking for problems, so... lets make sure user sees
> it.)

Please see the new version of this patch:
https://patchwork.kernel.org/patch/9226837/

Thanks,
Rafael

Thread

Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Pavel Machek <pavel@ucw.cz> - 2016-07-13 12:00 +0200
  Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Chen Yu <yu.c.chen@intel.com> - 2016-07-13 12:20 +0200
    Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Pavel Machek <pavel@ucw.cz> - 2016-07-13 12:30 +0200
      Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Chen Yu <yu.c.chen@intel.com> - 2016-07-13 12:40 +0200
        Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Pavel Machek <pavel@ucw.cz> - 2016-07-13 19:10 +0200
          Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-13 22:10 +0200
            Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Pavel Machek <pavel@ucw.cz> - 2016-07-13 22:30 +0200
              Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-13 22:50 +0200
                Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Pavel Machek <pavel@ucw.cz> - 2016-07-13 23:50 +0200
                Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-14 00:10 +0200
                Re: [PATCH] PM / hibernate: Introduce snapshot test mode for hibernation "Rafael J. Wysocki" <rafael@kernel.org> - 2016-07-14 00:20 +0200
                Re: [PATCH] PM / hibernate: Introduce snapshot test mode for  hibernation Chen Yu <yu.c.chen@intel.com> - 2016-07-14 12:40 +0200

csiph-web