Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1442622

Re: [PATCH] coresight: Use local coresight_desc instances

From Suzuki K Poulose <Suzuki.Poulose@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] coresight: Use local coresight_desc instances
Date 2016-07-13 18:30 +0200
Message-ID <rUvcS-5vg-25@gated-at.bofh.it> (permalink)
References <rUvcS-5vg-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 13/07/16 17:21, kbuild test robot wrote:
> Hi,
>
> [auto build test ERROR on next-20160712]
> [cannot apply to v4.7-rc7 v4.7-rc6 v4.7-rc5 v4.7-rc7]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Suzuki-K-Poulose/coresight-Use-local-coresight_desc-instances/20160713-220832
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm
>
> All errors (new ones prefixed by >>):
>
>    drivers/hwtracing/coresight/coresight-replicator-qcom.c: In function 'replicator_probe':
>>> drivers/hwtracing/coresight/coresight-replicator-qcom.c:137:34: error: invalid type argument of unary '*' (have 'struct coresight_desc')
>      desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
>                                      ^
>>> drivers/hwtracing/coresight/coresight-replicator-qcom.c:138:6: error: wrong type argument to unary exclamation mark
>      if (!desc)
>          ^
>
> vim +137 drivers/hwtracing/coresight/coresight-replicator-qcom.c
>
> 620cf787 Pratik Patel     2015-05-19  131  		return PTR_ERR(base);
> 620cf787 Pratik Patel     2015-05-19  132
> 620cf787 Pratik Patel     2015-05-19  133  	drvdata->base = base;
> 620cf787 Pratik Patel     2015-05-19  134  	dev_set_drvdata(dev, drvdata);
> 620cf787 Pratik Patel     2015-05-19  135  	pm_runtime_put(&adev->dev);
> 620cf787 Pratik Patel     2015-05-19  136
> 620cf787 Pratik Patel     2015-05-19 @137  	desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
> 620cf787 Pratik Patel     2015-05-19 @138  	if (!desc)
> 620cf787 Pratik Patel     2015-05-19  139  		return -ENOMEM;
> 620cf787 Pratik Patel     2015-05-19  140
> 93c12082 Suzuki K Poulose 2016-07-13  141  	desc.type = CORESIGHT_DEV_TYPE_LINK;

ah, I didn't have the REPLICATOR_QCOM in my config, will fix this one. Thanks
for the report.

Suzuki

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] coresight: Use local coresight_desc instances Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-07-13 18:30 +0200

csiph-web