[PATCH] iio: stx104: Store channel output state values as int

From	William Breathitt Gray <vilhelm.gray@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] iio: stx104: Store channel output state values as int
Date	2016-07-13 16:50 +0200
Message-ID	<rUtE6-4my-25@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The val parameter has a data type of int in the read_raw and write_raw
callbacks. The chan_out_states array should have elements of type int in
order to match the data type of the val parameter.

This patch fixes a possible integer overflow condition when the the int
pointer val is dereferenced to store the unsigned int chan_out_states
element in the read_raw callback.

Fixes: 97a445dad37a ("iio: Add IIO support for the DAC on the Apex Embedded Systems STX104")
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/iio/dac/stx104.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/stx104.c b/drivers/iio/dac/stx104.c
index 792a971..b22b744 100644
--- a/drivers/iio/dac/stx104.c
+++ b/drivers/iio/dac/stx104.c
@@ -47,7 +47,7 @@ MODULE_PARM_DESC(base, "Apex Embedded Systems STX104 base addresses");
  * @base:		base port address of the IIO device
  */
 struct stx104_iio {
-	unsigned chan_out_states[STX104_NUM_CHAN];
+	int chan_out_states[STX104_NUM_CHAN];
 	unsigned base;
 };
 
-- 
2.7.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: stx104: Store channel output state values as int William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-13 16:50 +0200
  Re: [PATCH] iio: stx104: Store channel output state values as int Jonathan Cameron <jic23@kernel.org> - 2016-07-24 15:10 +0200
    Re: [PATCH] iio: stx104: Store channel output state values as int William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-07-25 14:50 +0200

csiph-web