[PATCH 8/9] overlayfs: Dilute permission checks on lower only if not special file

From	Vivek Goyal <vgoyal@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH 8/9] overlayfs: Dilute permission checks on lower only if not special file
Date	2016-07-13 16:50 +0200
Message-ID	<rUtE5-4my-9@gated-at.bofh.it> (permalink)
References	<rUtE5-4my-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Right now if file is on lower/, we remove MAY_WRITE/MAY_APPEND bits from
mask as lower/ will never be written and file will be copied up. But this
is not true for special files. These files are not copied up and are
opened in place. So don't dilute the checks for these types of files.

Reported-by: Dan Walsh <dwalsh@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 fs/overlayfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 66f42f5..6d9d86e 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -140,7 +140,7 @@ int ovl_permission(struct inode *inode, int mask)
 		return err;
 
 	old_cred = ovl_override_creds(inode->i_sb);
-	if (!is_upper)
+	if (!is_upper && !special_file(realinode->i_mode))
 		mask &= ~(MAY_WRITE | MAY_APPEND);
 	err = inode_permission(realinode, mask);
 	revert_creds(old_cred);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 8/9] overlayfs: Dilute permission checks on lower only if not special file Vivek Goyal <vgoyal@redhat.com> - 2016-07-13 16:50 +0200
  Re: [PATCH 8/9] overlayfs: Dilute permission checks on lower only if  not special file Miklos Szeredi <miklos@szeredi.hu> - 2016-07-14 09:00 +0200

csiph-web