Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1442440

Re: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per resources

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per resources
Date 2016-07-13 15:20 +0200
Message-ID <rUseZ-3yv-5@gated-at.bofh.it> (permalink)
References <rUe2l-2xx-3@gated-at.bofh.it> <rUe2m-2xx-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 12 Jul 2016, Fenghua Yu wrote:

> From: Fenghua Yu <fenghua.yu@intel.com>
> 
> QoS mask MSRs array is per cache. We need to allocate CLOSID per cache
> instead global CLOSID.
> 
> A few different resources can share same QoS mask MSRs array. For
> example, one L2 cache can share QoS MSRs with its next level
> L3 cache. A domain number represents the L2 cache, the L3 cache, the L2
> cache's shared cpumask, and the L3 cache's shared cpumask.
> 
> cctable is extended to be index by domain number so that each cache
> has its own control table.
> 
> shared_domain is introduced to cover multiple resources sharing
> CLOSID.

This patch does a dozen different things at once. Can you please split the
cleanup parts, the parts where statics are removed and the actual changes in
the representation model apart so this can be reviewed?

And while at this, please fold back thes cleanups into the original
patches. There is no point to have these changes seperate.

Thanks,

	tglx

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per resources "Fenghua Yu" <fenghua.yu@intel.com> - 2016-07-13 00:10 +0200
  Re: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per  resources Thomas Gleixner <tglx@linutronix.de> - 2016-07-13 15:20 +0200
    RE: [PATCH 23/32] x86/intel_rdt.c: Extend RDT to per cache and per  resources "Yu, Fenghua" <fenghua.yu@intel.com> - 2016-07-13 19:50 +0200

csiph-web