Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable
Date	2016-07-13 16:00 +0200
Message-ID	<rUsRI-3OH-41@gated-at.bofh.it> (permalink)
References	(6 earlier) <rodnY-4BO-5@gated-at.bofh.it> <rSdtM-4Uf-29@gated-at.bofh.it> <rSofv-3qc-9@gated-at.bofh.it> <rTK4i-842-31@gated-at.bofh.it> <rU9P5-85j-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 12 Jul 2016, Cong Wang wrote:

> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index f45929c..0b5c172e 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -52,6 +52,7 @@
> >  #include <uapi/linux/netdevice.h>
> >  #include <uapi/linux/if_bonding.h>
> >  #include <uapi/linux/pkt_cls.h>
> > +#include <linux/hashtable.h>
> >
> >  struct netpoll_info;
> >  struct device;
> > @@ -1778,6 +1779,7 @@ struct net_device {
> >         unsigned int            num_tx_queues;
> >         unsigned int            real_num_tx_queues;
> >         struct Qdisc            *qdisc;
> > +       DECLARE_HASHTABLE       (qdisc_hash, 4);
> >         unsigned long           tx_queue_len;
> >         spinlock_t              tx_global_lock;
> >         int                     watchdog_timeo;
> 
> Should it be surrounded by CONFIG_NET_SCHED?
> To save several bytes for !CONFIG_NET_SCHED case.

Makes sense. I'll wait a bit for more feedback (if there is any) before 
including this in potential v4.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v3] net: sched: convert qdisc linked list to hashtable Jiri Kosina <jikos@kernel.org> - 2016-07-11 16:10 +0200
  Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable Cong Wang <xiyou.wangcong@gmail.com> - 2016-07-12 19:40 +0200
    Re: [RFC PATCH v3] net: sched: convert qdisc linked list to  hashtable Jiri Kosina <jikos@kernel.org> - 2016-07-13 16:00 +0200

csiph-web