Re: [PATCH -next] drm: atmel-hlcdc: fix non static symbol warning

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] drm: atmel-hlcdc: fix non static symbol warning
Date	2016-07-13 15:10 +0200
Message-ID	<rUs5k-3uO-25@gated-at.bofh.it> (permalink)
References	<rUrLZ-38m-39@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

On Wed, 13 Jul 2016 12:43:03 +0000
weiyj_lk@163.com wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning:
>  symbol 'atmel_hlcdc_crtc_reset' was not declared. Should it be static?

Sorry but Thierry already proposed the same fix a few days ago.

> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> index a978381..9b17a66 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> @@ -387,7 +387,7 @@ void atmel_hlcdc_crtc_irq(struct drm_crtc *c)
>  	atmel_hlcdc_crtc_finish_page_flip(drm_crtc_to_atmel_hlcdc_crtc(c));
>  }
>  
> -void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc)
> +static void atmel_hlcdc_crtc_reset(struct drm_crtc *crtc)
>  {
>  	struct atmel_hlcdc_crtc_state *state;
>  
> 
> 
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm: atmel-hlcdc: fix non static symbol warning weiyj_lk@163.com - 2016-07-13 14:50 +0200
  Re: [PATCH -next] drm: atmel-hlcdc: fix non static symbol warning Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-07-13 15:10 +0200

csiph-web