Re: [PATCH 1/2] Add a kexec_crash_loaded() function

From	Petr Tesarik <ptesarik@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Add a kexec_crash_loaded() function
Date	2016-07-13 15:10 +0200
Message-ID	<rUs5k-3uO-23@gated-at.bofh.it> (permalink)
References	<rUrsB-30I-3@gated-at.bofh.it> <rUrsC-30I-25@gated-at.bofh.it> <rUrVE-3bS-27@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Wed, 13 Jul 2016 05:52:33 -0700
Josh Triplett <josh@joshtriplett.org> wrote:

> On Wed, Jul 13, 2016 at 02:19:55PM +0200, Petr Tesarik wrote:
> > --- a/kernel/kexec_core.c
> > +++ b/kernel/kexec_core.c
> > @@ -95,6 +95,12 @@ int kexec_should_crash(struct task_struct *p)
> >  	return 0;
> >  }
> >  
> > +int kexec_crash_loaded(void)
> > +{
> > +	return !!kexec_crash_image;
> > +}
> 
> Nit: this function should return bool rather than int, since it
> effectively returns true/false.

I thought about this for a moment. Since the return value should also
be used for the corresponding sysctl, which is an integer, I wasn't
sure if bool is the correct type, especially since other boolean
functions in kexec.h also return int... But that could be legacy.

I've got no problem changing the type to 'bool' if that's what it takes.

Petr T

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Add a kexec_crash_loaded() function Petr Tesarik <ptesarik@suse.com> - 2016-07-13 14:30 +0200
  Re: [PATCH 1/2] Add a kexec_crash_loaded() function Josh Triplett <josh@joshtriplett.org> - 2016-07-13 15:00 +0200
    Re: [PATCH 1/2] Add a kexec_crash_loaded() function Petr Tesarik <ptesarik@suse.com> - 2016-07-13 15:10 +0200

csiph-web