Re: [PATCH v7 1/2] mm, kasan: account for object redzone in SLUB's nearest_obj()

From	Alexander Potapenko <glider@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/2] mm, kasan: account for object redzone in SLUB's nearest_obj()
Date	2016-07-13 14:20 +0200
Message-ID	<rUriV-2WY-5@gated-at.bofh.it> (permalink)
References	<rUarL-7W-3@gated-at.bofh.it> <rUarM-7W-7@gated-at.bofh.it> <rUcae-1jn-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Changed the description as follows:

=================================
    mm, kasan: account for object redzone in SLUB's nearest_obj()

    When looking up the nearest SLUB object for a given address, correctly
    calculate its offset if SLAB_RED_ZONE is enabled for that cache.

    Previously, when KASAN had detected an error on an object from a cache
    with SLAB_RED_ZONE set, the actual start address of the object was
    miscalculated, which led to random stacks having been reported.

    Fixes: 7ed2f9e663854db ("mm, kasan: SLAB support")
    Signed-off-by: Alexander Potapenko <glider@google.com>
=================================

To avoid sending both patches and the cover page again, I'm going to
wait for other comments.

On Tue, Jul 12, 2016 at 10:02 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Tue, 12 Jul 2016 20:12:44 +0200 Alexander Potapenko <glider@google.com> wrote:
>
>> When looking up the nearest SLUB object for a given address, correctly
>> calculate its offset if SLAB_RED_ZONE is enabled for that cache.
>
> What are the runtime effects of this fix?  Please always include this
> info when fixing bugs so that others can decide which kernel(s) need
> patching.
>



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 1/2] mm, kasan: account for object redzone in SLUB's nearest_obj() Alexander Potapenko <glider@google.com> - 2016-07-12 20:20 +0200
  Re: [PATCH v7 1/2] mm, kasan: account for object redzone in SLUB's  nearest_obj() Andrew Morton <akpm@linux-foundation.org> - 2016-07-12 22:10 +0200
    Re: [PATCH v7 1/2] mm, kasan: account for object redzone in SLUB's nearest_obj() Alexander Potapenko <glider@google.com> - 2016-07-13 14:20 +0200

csiph-web