Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

From	Samuel Ortiz <sameo@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status
Date	2016-07-13 13:10 +0200
Message-ID	<rUqdc-2hi-9@gated-at.bofh.it> (permalink)
References	<rGYHL-2R8-7@gated-at.bofh.it> <rUpTQ-1UQ-31@gated-at.bofh.it> <rUq3w-1YL-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marcel,

On Wed, Jul 13, 2016 at 11:56:02AM +0100, Marcel Holtmann wrote:
> Hi Mauro,
> 
> >> On mips and parisc:
> >> 
> >>    drivers/bluetooth/btwilink.c: In function 'ti_st_open':
> >>    drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit constant conversion [-Woverflow]
> >>       hst->reg_status = -EINPROGRESS;
> >> 
> >>    drivers/nfc/nfcwilink.c: In function 'nfcwilink_open':
> >>    drivers/nfc/nfcwilink.c:396:31: warning: overflow in implicit constant conversion [-Woverflow]
> >>      drv->st_register_cb_status = -EINPROGRESS;
> >> 
> >> There are actually two issues:
> >>  1. Whether "char" is signed or unsigned depends on the architecture.
> >>     As the completion callback data is used to pass a (negative) error
> >>     code, it should always be signed.
> >>  2. EINPROGRESS is 150 on mips, 245 on parisc.
> >>     Hence -EINPROGRESS doesn't fit in a signed 8-bit number.
> >> 
> >> Change the callback status from "char" to "int" to fix these.
> >> 
> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > 
> > Patch looks sane to me, but who will apply it?
> > 
> > Anyway:
> > 
> > Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> 
> I can take it through bluetooth-next if there is no objection.
> 
> Samuel, are you fine with that?
Yes, please go ahead.

Cheers,
Samuel.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for  callback status Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-07-13 12:50 +0200
  Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status Marcel Holtmann <marcel@holtmann.org> - 2016-07-13 13:00 +0200
    Re: [PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for  callback status Samuel Ortiz <sameo@linux.intel.com> - 2016-07-13 13:10 +0200

csiph-web