Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1442285

Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP

From Yang Zhang <yang.zhang.wz@gmail.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP
Date 2016-07-13 12:10 +0200
Message-ID <rUph7-1FZ-5@gated-at.bofh.it> (permalink)
References <rUbxw-Oh-21@gated-at.bofh.it> <rUbxw-Oh-27@gated-at.bofh.it> <rUoEp-13x-17@gated-at.bofh.it> <rUoO6-17A-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 2016/7/13 17:35, Paolo Bonzini wrote:
>
>
> On 13/07/2016 11:21, Yang Zhang wrote:
>>>
>>> +static int handle_desc(struct kvm_vcpu *vcpu)
>>> +{
>>> +    WARN_ON(!(vcpu->arch.cr4 & X86_CR4_UMIP));
>>
>> I think WARN_ON is too heavy since a malicious guest may trigger it always.
>
> I missed this---how so?  Setting the bit is under "if ((cr4 &
> X86_CR4_UMIP) && !boot_cpu_has(X86_FEATURE_UMIP))".

Sorry, I consider it under my previous suggestion(setting it 
unconditionally). :(

-- 
Yang
Alibaba Cloud Computing

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-07-12 21:30 +0200
  Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Yang Zhang <yang.zhang.wz@gmail.com> - 2016-07-13 11:30 +0200
    Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-07-13 11:40 +0200
      Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Yang Zhang <yang.zhang.wz@gmail.com> - 2016-07-13 12:00 +0200
    Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-07-13 11:40 +0200
      Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Yang Zhang <yang.zhang.wz@gmail.com> - 2016-07-13 12:10 +0200
        Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-07-13 12:30 +0200
  Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Radim Krčmář <rkrcmar@redhat.com> - 2016-07-13 22:40 +0200
    Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-07-14 10:20 +0200
      Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Radim Krčmář <rkrcmar@redhat.com> - 2016-07-14 14:40 +0200
        Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-07-14 15:00 +0200

csiph-web