Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1442323
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/9] async: Extend kfence to allow struct embedding |
| Date | 2016-07-13 12:40 +0200 |
| Message-ID | <rUpKb-1QV-33@gated-at.bofh.it> (permalink) |
| References | <rNvhE-6a1-29@gated-at.bofh.it> <rNvrj-6dp-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 24, 2016 at 10:08:47AM +0100, Chris Wilson wrote:
> @@ -151,7 +161,11 @@ static void kfence_free(struct kref *kref)
>
> WARN_ON(atomic_read(&fence->pending) > 0);
>
> - kfree(fence);
> + if (fence->flags) {
> + kfence_notify_t fn = (kfence_notify_t)fence->flags;
Maybe provide an inline helper for that conversion and also mask out the
low bits, just to be careful. You're assuming they're not set here,
which seems like a dangerous thing.
> + fn(fence);
> + } else
> + kfree(fence);
Also Codingstyle wants braces on both branches if its on one.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 3/9] async: Extend kfence to allow struct embedding Peter Zijlstra <peterz@infradead.org> - 2016-07-13 12:40 +0200
csiph-web