Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1442157

Re: [PATCH] drm/amdkfd: print doorbell offset as a hex value

Show all headers | View raw

On Wed, Jul 13, 2016 at 10:36 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The doorbell offset is formatted with a 0x prefix to suggest it is
> a hexadecimal value, when in fact %d is being used and this is confusing.
> Use %X instead to match the proceeding 0x prefix.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c b/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c
> index e621eba..a7d3cb3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c
> @@ -184,7 +184,7 @@ u32 __iomem *kfd_get_kernel_doorbell(struct kfd_dev *kfd,
>                                                         sizeof(u32)) + inx;
>
>         pr_debug("kfd: get kernel queue doorbell\n"
> -                        "     doorbell offset   == 0x%08d\n"
> +                        "     doorbell offset   == 0x%08X\n"
>                          "     kernel address    == 0x%08lX\n",
>                 *doorbell_off, (uintptr_t)(kfd->doorbell_kernel_ptr + inx));
>
> --
> 2.8.1
>

Thanks,
Applied to my -fixes tree

    Oded

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/amdkfd: print doorbell offset as a hex value Colin King <colin.king@canonical.com> - 2016-07-13 09:40 +0200
  Re: [PATCH] drm/amdkfd: print doorbell offset as a hex value Oded Gabbay <oded.gabbay@gmail.com> - 2016-07-13 10:20 +0200

csiph-web