Re: [PATCH 10/10] perf script python: Fix string vs byte array resolving

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/10] perf script python: Fix string vs byte array resolving
Date	2016-07-12 21:30 +0200
Message-ID	<rUbxv-Oh-13@gated-at.bofh.it> (permalink)
References	(4 earlier) <rU58K-4Sa-15@gated-at.bofh.it> <rU5s5-51i-9@gated-at.bofh.it> <rU5BM-5k0-51@gated-at.bofh.it> <rU64N-5xF-23@gated-at.bofh.it> <rU6eu-5CJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Tue, Jul 12, 2016 at 09:48:36AM -0400, Steven Rostedt escreveu:
> On Tue, 12 Jul 2016 15:35:52 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, Jul 12, 2016 at 09:00:01AM -0400, Steven Rostedt wrote:
> > > On Tue, 12 Jul 2016 14:52:45 +0200
> > > Jiri Olsa <jolsa@redhat.com> wrote:
> > > 
> > >   
> > > > hum, so string is not passed to trace buffer with 0 at the end?  
> > > 
> > > strlen() returns only the length of the string (minus the \0 at the
> > > end).  
> > 
> > yea, is_printable_array is called here on tracepoint
> > data that's why I asked.. is 0 part of the string data
> > when stored within tracepoint?
> 
> Good question. It may or may not (haven't looked at the code), but we
> probably want to make sure that the function is robust enough for
> either case.

Ok, applied and tested up to patch 9, waiting for this discussion to
come to an end to consider 10.

- Arnaldo
 
> > 
> > >   
> > > > 
> > > > I'll check the option of passing everything as PyByteArray.
> > > > If it's the same for user, we'll have simpler code in here.
> > > >   
> > > > > 
> > > > > because the last byte wont be 0. What about:
> > > > > 
> > > > > 	for (i = 0; i < len; i++)
> > > > > 		if (!isprint(p[i]) && !isspace(p[i]))
> > > > > 			break;
> > > > > 
> > > > > 	return i == len ||
> > > > > 		(i == len - 1 && p[i] == 0);    
> > > 
> > > Or you can do:
> > > 
> > > 	if (p[len - 1] == 0)
> > > 		len--;
> > > 
> > > 	for (i = 0; i < len; i++)
> > > 		if (!isprint(p[i]) && !isspace(p[i]))
> > > 			return 0;
> > > 	return 1;  
> > 
> > yep, seems good.. thanks
> > 
> 
> OK, great!
> 
> -- Steve

Thread

[PATCH 10/10] perf script python: Fix string vs byte array resolving Jiri Olsa <jolsa@kernel.org> - 2016-07-10 13:10 +0200
  Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-11 18:00 +0200
    Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-12 10:20 +0200
      Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-12 14:40 +0200
        Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-12 15:00 +0200
          Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-12 15:10 +0200
            Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-12 15:40 +0200
              Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-12 15:50 +0200
                Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-07-12 21:30 +0200
                Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Steven Rostedt <rostedt@goodmis.org> - 2016-07-12 21:50 +0200
                Re: [PATCH 10/10] perf script python: Fix string vs byte array  resolving Jiri Olsa <jolsa@redhat.com> - 2016-07-13 11:10 +0200

csiph-web