Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1441651

Re: [PATCH v2] spi: spi-topcliff-pch: Remove deprecated create_singlethread_workqueue

Show all headers | View raw

On Sun, Jul 10, 2016 at 07:42:13PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "wk" serves as a queue for carrying out execution
> of requests. It has a single work item(&drv_data->work) and hence doesn't
> require ordering. Also, it is not being used on a memory reclaim path.
> Hence, the singlethreaded workqueue has been replaced with the use of
> system_wq.
> 
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
> 
> Work item has been flushed in pch_spi_free_resources() to ensure that
> there are no pending tasks while disconnecting the driver.
> 
> Also dropped the label 'err_return' since it's not being used anymore.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] spi: spi-topcliff-pch: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-10 16:20 +0200
  Re: [PATCH v2] spi: spi-topcliff-pch: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-12 20:50 +0200

csiph-web