Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1441647

Re: [PATCH] drm/panel: Remove the get_timings() function.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Thierry Reding <thierry.reding@gmail.com> writes:

> On Wed, Jun 01, 2016 at 12:18:01PM -0700, Eric Anholt wrote:
>> It appears to have no callers.
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>  drivers/gpu/drm/panel/panel-simple.c | 18 ------------------
>>  include/drm/drm_panel.h              |  4 ----
>>  2 files changed, 22 deletions(-)
>
> Looks like I never replied to this, though I remember at least making up
> the reply in my head.
>
> The reason why I'd like to keep this is that it's technically the right
> interface for display drivers to use. It was introduced in order to fix
> some of the short-comings of ->get_modes(), though it seems like there
> simply hasn't been a need so far for drivers to do this.

OK.  That makes some sense then.  I was writing a new panel driver, and
it was confusing to have this unused code in panel-simple that I was
deriving from.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drm/panel: Remove the get_timings() function. Thierry Reding <thierry.reding@gmail.com> - 2016-07-11 14:40 +0200
  Re: [PATCH] drm/panel: Remove the get_timings() function. Eric Anholt <eric@anholt.net> - 2016-07-12 20:30 +0200

csiph-web