Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1443831
| From | Boqun Feng <boqun.feng@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian |
| Date | 2016-07-15 02:40 +0200 |
| Message-ID | <rUZkB-8jI-3@gated-at.bofh.it> (permalink) |
| References | <rM0SB-4FY-19@gated-at.bofh.it> <rUyu5-7yz-11@gated-at.bofh.it> <rUJzb-6C2-13@gated-at.bofh.it> <rULhE-7Tt-13@gated-at.bofh.it> <rULrj-7WZ-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Jul 14, 2016 at 11:46:26AM +0200, Peter Zijlstra wrote:
> On Thu, Jul 14, 2016 at 11:37:33AM +0200, Peter Zijlstra wrote:
> > static inline u8 *__qspinlock_lock_byte(struct qspinlock *lock)
> > {
> > return (u8 *)lock + 3 * IS_BUILTIN(__BIG_ENDIAN);
> > }
>
> Bugger, that doesn't actually work. IS_BUILTIN expects the symbol to be
> defined to "1" and __BIG_ENDIAN is not (its "4321").
>
>
Using IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN) instead? Seems ARM and PPC both
define this properly if the target kernel is a big endian one.
Regards,
Boqun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian Peter Zijlstra <peterz@infradead.org> - 2016-07-13 22:00 +0200
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian Peter Zijlstra <peterz@infradead.org> - 2016-07-13 22:50 +0200
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian xinhui <xinhui.pan@linux.vnet.ibm.com> - 2016-07-14 09:50 +0200
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian Peter Zijlstra <peterz@infradead.org> - 2016-07-14 11:40 +0200
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian Peter Zijlstra <peterz@infradead.org> - 2016-07-14 11:50 +0200
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian Boqun Feng <boqun.feng@gmail.com> - 2016-07-15 02:40 +0200
Re: [PATCH v3] locking/qrwlock: Let qrwlock has same layout regardless of the endian panxinhui <xinhui@linux.vnet.ibm.com> - 2016-07-15 08:30 +0200
csiph-web