Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1443614

Re: [patch net-next 2/2] devlink: fix trace format string

Show all headers | View raw

On Thu, 14 Jul 2016 10:07:38 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 07/14/16 02:37, Jiri Pirko wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Including devlink.h on ARM and probably other 32-bit architectures results in
> > a harmless warning:
> > 
> > In file included from ../include/trace/define_trace.h:95:0,
> >                  from ../include/trace/events/devlink.h:51,
> >                  from ../net/core/devlink.c:30:
> > include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
> > include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]
> > 
> > The correct format string for 'size_t' is %zu, not %lu, this works on all
> > architectures.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
> > Signed-off-by: Jiri Pirko <jiri@mellanox.com>  
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 

ditto!

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch net-next 2/2] devlink: fix trace format string Jiri Pirko <jiri@resnulli.us> - 2016-07-14 11:40 +0200
  Re: [patch net-next 2/2] devlink: fix trace format string Randy Dunlap <rdunlap@infradead.org> - 2016-07-14 19:10 +0200
    Re: [patch net-next 2/2] devlink: fix trace format string Steven Rostedt <rostedt@goodmis.org> - 2016-07-14 19:20 +0200
  Re: [patch net-next 2/2] devlink: fix trace format string David Miller <davem@davemloft.net> - 2016-07-15 07:20 +0200

csiph-web