Re: [PATCH] mtd: nand: omap2: add missing braces

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: omap2: add missing braces
Date	Thu, 14 Jul 2016 18:00:02 +0200
Message-ID	<rURdo-389-11@gated-at.bofh.it> (permalink)
References	<rULAZ-81N-5@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Gx0s3NQj5kQVCzNuLJW4xGmeKTR0ttJNzrATC93UnVk=; b=jKhvjYUUgvnjXhwTPvKFSyIvrP/XRjuKhzNeNz+PzdeoISyxHXsh/MC7kwmt07eb0S f7WKAxSKUjhgTLVadeMQRM1YjLljVTkGs2UZfH4ySu3L4dEmoML30tx/2pu/3O1Sc6xT 2Ou3Id9efiavafTLSJsODtDJC9jQlcYE3P93+H8/nehkHaWDJJgm1kYE9OUOG9JGMkM4 Xd1WgES1k/65zm6tmcAWzPyrQWo/eNXe8AJgibi/CY3W84m5dRyGYq+rVvQMajeJoQpE suyMaGkB08icPvxnLhOvaMERrwQ1gPvjELDsS29+gdcnyx1JUuQ7NHiLFKZmGCDjc7M4 HnQw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gx0s3NQj5kQVCzNuLJW4xGmeKTR0ttJNzrATC93UnVk=; b=c7UTjBdoiQVmUWd/JHTqpYOuawz98Q4QG0ArDEsgazz9F27nk7b3wLkBI2vs8nwNkB 0cjd2EH4C6nZmBRY19xJJR7gQUWBSsF4bys4jrvjTVknaanT92EcGGMPFwdJdahPYNDK wkjbOVrtgRGXnYVrU1SrnTGmACJ8LySBbaIqTeEqRv7MderC6RETrjI7WSFhfIVb1xIF ZfvN8SZ1P50XHkDYqmms8gXW6lMLytm6Ci9IgP8vzsPqAwCZ0l+HplTuuSpXVSxbeCh6 BXFjeVQG7VT/7Og3IwHLT3Q+Cx1SW3oXyQIEFhk3+ZPyy9rwMvT2wDfsUwiuL91NVz3R /lVA==
X-Gm-Message-State	ALyK8tIW+V/W/fMxZCSbR77aCKQ+khOxGaXE/xRKtiSbILT8ucjKmNnr2UlVPj60Nr60Vw==
X-Received	by 10.66.15.138 with SMTP id x10mr23586537pac.92.1468511937761; Thu, 14 Jul 2016 08:58:57 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	Teresa Remmet <t.remmet@phytec.de>, Boris Brezillon <boris.brezillon@free-electrons.com>, Richard Weinberger <richard@nod.at>, David Woodhouse <dwmw2@infradead.org>, Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>, "Cooper Jr., Franklin" <fcooper@ti.com>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 14 Jul 2016 08:58:49 -0700
X-Original-Message-ID	<20160714155849.GA120073@google.com>
X-Original-References	<20160714095416.739127-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1443552

Show key headers only | View raw

On Thu, Jul 14, 2016 at 11:53:48AM +0200, Arnd Bergmann wrote:
> A bug fix just introduced incorrect behavior in the omap2 nand driver, as
> found by gcc-6.1:
> 
> drivers/mtd/nand/omap2.c: In function 'omap_get_dt_info':
> drivers/mtd/nand/omap2.c:1658:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>   if (!info->elm_of_node)
>   ^~
> drivers/mtd/nand/omap2.c:1660:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
>    if (!info->elm_of_node)
>    ^~
> 
> We clearly need to put the indented code into { } braces to get the intended
> behavior.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3bbca2c54f86 ("mtd: nand: omap2: Add check for old elm binding")

Wow, can't believe I missed that. Squashed into the original patch.

Thanks,
Brian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: omap2: add missing braces Arnd Bergmann <arnd@arndb.de> - 2016-07-14 12:00 +0200
  Re: [PATCH] mtd: nand: omap2: add missing braces Teresa Remmet <t.remmet@phytec.de> - 2016-07-14 15:10 +0200
  Re: [PATCH] mtd: nand: omap2: add missing braces Brian Norris <computersforpeace@gmail.com> - 2016-07-14 18:00 +0200

csiph-web