[PATCH] [media] vb2: include length in dmabuf qbuf debug message

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] [media] vb2: include length in dmabuf qbuf debug message
Date	2016-07-14 17:20 +0200
Message-ID	<rUQAF-2UX-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If the the VIDIOC_QBUF ioctl fails due a wrong dmabuf length,
it's useful to get the invalid length as a debug information.

Before this patch:

vb2-core: __qbuf_dmabuf: invalid dmabuf length for plane 1

After this patch:

vb2-core: __qbuf_dmabuf: invalid dmabuf length 221248 for plane 1

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/media/v4l2-core/videobuf2-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index ca8ffeb56d72..97d1483e0f7a 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -1228,8 +1228,8 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
 			planes[plane].length = dbuf->size;
 
 		if (planes[plane].length < vb->planes[plane].min_length) {
-			dprintk(1, "invalid dmabuf length for plane %d\n",
-				plane);
+			dprintk(1, "invalid dmabuf length %d for plane %d\n",
+				planes[plane].length, plane);
 			dma_buf_put(dbuf);
 			ret = -EINVAL;
 			goto err;
-- 
2.5.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] vb2: include length in dmabuf qbuf debug message Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-14 17:20 +0200
  Re: [PATCH] [media] vb2: include length in dmabuf qbuf debug message Sakari Ailus <sakari.ailus@iki.fi> - 2016-07-20 15:10 +0200
    Re: [PATCH] [media] vb2: include length in dmabuf qbuf debug message Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-20 15:40 +0200

csiph-web