Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1443479
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usb: ehci-platform: use helper variables in probe function |
| Date | 2016-07-14 16:20 +0200 |
| Message-ID | <rUPEC-2l6-31@gated-at.bofh.it> (permalink) |
| References | <rUnS2-vb-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 13 Jul 2016, Rafał Miłecki wrote: > Probing function was using &dev->dev and dev->dev.of_node over 20 times > so I believe it made sense to use helper variables for both of them. > To avoid some uncommon variable name for struct device I first replaced > existing dev variable with pdev. > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> Okay except for... > - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node, > - "phys", "#phy-cells"); > + priv->num_phys = of_count_phandle_with_args(np, "phys", > + "#phy-cells"); Please indent continuation lines two tab stops beyond the original line, to match the style in the rest of the source file. With that change, Acked-by: Alan Stern <stern@rowland.harvard.edu> Alan Stern
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: ehci-platform: use helper variables in probe function Rafał Miłecki <zajec5@gmail.com> - 2016-07-13 10:40 +0200
Re: [PATCH] usb: ehci-platform: use helper variables in probe function Alan Stern <stern@rowland.harvard.edu> - 2016-07-14 16:20 +0200
Re: [PATCH] usb: ehci-platform: use helper variables in probe function Rafał Miłecki <zajec5@gmail.com> - 2016-07-14 17:30 +0200
Re: [PATCH] usb: ehci-platform: use helper variables in probe function Alan Stern <stern@rowland.harvard.edu> - 2016-07-15 03:00 +0200
[PATCH V2] usb: ehci-platform: use helper variables in probe function Rafał Miłecki <zajec5@gmail.com> - 2016-07-15 07:10 +0200
csiph-web