Re: [patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop()

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop()
Date	2016-07-14 15:10 +0200
Message-ID	<rUOyS-1GD-23@gated-at.bofh.it> (permalink)
References	<rUNjs-JL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Dan Carpenter <dan.carpenter@oracle.com> wrote:

> If strndup_user() user fails then it returns an error pointer and we
> pass that to kfree() which causes an oops.

Hm, in addition to this fix wouldn't it be better to not crash if kfree() gets 
passed an error pointer? Would that have changed the pattern of this particular 
bug?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch 1/2] drivers/virt: fix the error handling in ioctl_dtprop() Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-14 13:50 +0200
  Re: [patch 1/2] drivers/virt: fix the error handling in  ioctl_dtprop() Ingo Molnar <mingo@kernel.org> - 2016-07-14 15:10 +0200

csiph-web