[patch] netiucv: silence an underflow warning

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] netiucv: silence an underflow warning
Date	2016-07-14 13:40 +0200
Message-ID	<rUN9L-G3-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

I haven't looked at the implications but we accidentally allow bs1 to
be negative.  It makes my static checker complain.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/s390/net/netiucv.c b/drivers/s390/net/netiucv.c
index b0e8ffd..85a5744 100644
--- a/drivers/s390/net/netiucv.c
+++ b/drivers/s390/net/netiucv.c
@@ -1578,7 +1578,7 @@ static ssize_t buffer_write (struct device *dev, struct device_attribute *attr,
 			*e);
 		return -EINVAL;
 	}
-	if (bs1 > NETIUCV_BUFSIZE_MAX) {
+	if (bs1 < 0 || bs1 > NETIUCV_BUFSIZE_MAX) {
 		IUCV_DBF_TEXT_(setup, 2,
 			"buffer_write: buffer size %d too large\n",
 			bs1);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] netiucv: silence an underflow warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-14 13:40 +0200
  Re: [patch] netiucv: silence an underflow warning Ursula Braun <ubraun@linux.vnet.ibm.com> - 2016-07-15 09:20 +0200
    Re: [patch] netiucv: silence an underflow warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-07-15 10:40 +0200

csiph-web