Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state after failing adaptive locking spinning

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state after failing adaptive locking spinning
Date	2016-07-14 13:30 +0200
Message-ID	<rUN06-BW-21@gated-at.bofh.it> (permalink)
References	<rUK2l-75j-221@gated-at.bofh.it> <rUN06-BW-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-07-14 19:26 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
> On Thu, Jul 14, 2016 at 04:15:56PM +0800, Wanpeng Li wrote:
>> In this case, lock holder inserts the pv_node of queue head into the
>> hash table and set _Q_SLOW_VAL unnecessary. This patch avoids it by
>> restoring/setting vcpu_halted state after failing adaptive locking
>                         ^^^^^^
>> spinning.
>>
>
>> -             WRITE_ONCE(pn->state, vcpu_halted);
>> +             WRITE_ONCE(pn->state, vcpu_hashed);
>                                            ^^^^^^
>
> The Changelog meant so say vcpu_hashed, surely?

Oh, there is a typo in changelog, I will fix it.

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state after failing adaptive locking spinning Wanpeng Li <kernellwp@gmail.com> - 2016-07-14 10:20 +0200
  Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state  after failing adaptive locking spinning Peter Zijlstra <peterz@infradead.org> - 2016-07-14 13:30 +0200
    Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state  after failing adaptive locking spinning Wanpeng Li <kernellwp@gmail.com> - 2016-07-14 13:30 +0200

csiph-web