[PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Andrew Duggan <aduggan@synaptics.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree
Date	Thu, 14 Jul 2016 08:10:01 +0200
Message-ID	<rUI0p-5LE-9@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.5.0
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.4.10.103]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Duggan <aduggan@synaptics.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Vincent Huang <vincent.huang@tw.synaptics.com>, Nick Dyer <nick@shmanahar.org>, Chris Healy <cphealy@gmail.com>, <devicetree@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh@kernel.org>
X-Original-Date	Wed, 13 Jul 2016 23:08:42 -0700
X-Original-Message-ID	<1468476522-8032-1-git-send-email-aduggan@synaptics.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1443084

Show key headers only | View raw

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
This version includes Nick's suggestion of adding force to the device tree
parameters so make it obvious that these parameters overwrite the
default values set in the firware config.

 .../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt        | 10 ++++++++++
 drivers/input/rmi4/rmi_2d_sensor.c                          | 13 +++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
index f2c30c8..c00665d 100644
--- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
+++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
@@ -37,6 +37,16 @@ Optional Properties:
 				disable reporing absolute position data.
 - syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero
 				command.
+- syna,dribble-force-enable: Enable reporting of dribble packets in the firmware
+				(overwrites default value in firmware config).
+- syna,dribble-force-disable: Disable reporting of dribble packets in the firmware.
+				(overwrites default value in firmware config).
+- syna,palm-detect-force-enable: Enable reporting the palm detect gesture in the
+				firmware.  (overwrites default value in firmware
+				config).
+- syna,palm-detect-force-disable: Disable reporting the palm detect gesture in
+				the firmware.  (overwrites default value in
+				firmware config).
 
 
 Example of a RMI4 I2C device with F11:
diff --git a/drivers/input/rmi4/rmi_2d_sensor.c b/drivers/input/rmi4/rmi_2d_sensor.c
index e97bd7f..a092f6a 100644
--- a/drivers/input/rmi4/rmi_2d_sensor.c
+++ b/drivers/input/rmi4/rmi_2d_sensor.c
@@ -317,6 +317,19 @@ int rmi_2d_sensor_of_probe(struct device *dev,
 
 	pdata->rezero_wait = val;
 
+	if (of_property_read_bool(dev->of_node, "syna,dribble-force-enable"))
+		pdata->dribble = RMI_REG_STATE_ON;
+	else if (of_property_read_bool(dev->of_node,
+	    "syna,dribble-force-disable"))
+		pdata->dribble = RMI_REG_STATE_OFF;
+
+	if (of_property_read_bool(dev->of_node,
+	    "syna,palm-detect-force-enable"))
+		pdata->palm_detect = RMI_REG_STATE_ON;
+	else if (of_property_read_bool(dev->of_node,
+				"syna,palm-detect-force-disable"))
+		pdata->palm_detect = RMI_REG_STATE_OFF;
+
 	return 0;
 }
 #else
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree Andrew Duggan <aduggan@synaptics.com> - 2016-07-14 08:10 +0200
  Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm  gesture parameters to device tree Rob Herring <robh@kernel.org> - 2016-07-17 00:50 +0200
  Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm  gesture parameters to device tree Linus Walleij <linus.walleij@linaro.org> - 2016-07-22 17:10 +0200
  Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm  gesture parameters to device tree Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-22 19:00 +0200
    Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm  gesture parameters to device tree Andrew Duggan <aduggan@synaptics.com> - 2016-07-22 20:40 +0200
      Re: [PATCH v3 3/8] Input: synaptics-rmi4: Add dribble and palm  gesture parameters to device tree Linus Walleij <linus.walleij@linaro.org> - 2016-07-24 16:30 +0200

csiph-web