[PATCH v3 1/8] Input: synaptics-rmi4: Use of_get_child_by_name() instead of of_find_node_by_name()

Path	csiph.com!news.freedyn.net!newsfeed.datemas.de!news.albasani.net!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Andrew Duggan <aduggan@synaptics.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 1/8] Input: synaptics-rmi4: Use of_get_child_by_name() instead of of_find_node_by_name()
Date	Thu, 14 Jul 2016 08:10:01 +0200
Message-ID	<rUI0p-5LE-13@gated-at.bofh.it> (permalink)
X-Original-To	<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Mailer	git-send-email 2.5.0
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.4.10.103]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Duggan <aduggan@synaptics.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Vincent Huang <vincent.huang@tw.synaptics.com>, Nick Dyer <nick@shmanahar.org>, Chris Healy <cphealy@gmail.com>
X-Original-Date	Wed, 13 Jul 2016 23:08:08 -0700
X-Original-Message-ID	<1468476488-7935-1-git-send-email-aduggan@synaptics.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1443085

Show key headers only | View raw

Calling of_find_node_by_name() assumes that the caller has incremented
the refcount of the of_node being passed in. Currently, the caller is
not incrementing the refcount of the of_node which results in the node
being prematurely freed when of_find_node_by_name() calls of_node_put()
on it. Instead use of_get_child_by_name() which does not call put on the
of_node.

Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
---
 drivers/input/rmi4/rmi_bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
index b368b05..253df96 100644
--- a/drivers/input/rmi4/rmi_bus.c
+++ b/drivers/input/rmi4/rmi_bus.c
@@ -157,11 +157,11 @@ static int rmi_function_match(struct device *dev, struct device_driver *drv)
 static void rmi_function_of_probe(struct rmi_function *fn)
 {
 	char of_name[9];
+	struct device_node *node = fn->rmi_dev->xport->dev->of_node;
 
 	snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
 		fn->fd.function_number);
-	fn->dev.of_node = of_find_node_by_name(
-				fn->rmi_dev->xport->dev->of_node, of_name);
+	fn->dev.of_node = of_get_child_by_name(node, of_name);
 }
 #else
 static inline void rmi_function_of_probe(struct rmi_function *fn)
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/8] Input: synaptics-rmi4: Use of_get_child_by_name() instead of of_find_node_by_name() Andrew Duggan <aduggan@synaptics.com> - 2016-07-14 08:10 +0200
  Re: [PATCH v3 1/8] Input: synaptics-rmi4: Use of_get_child_by_name()  instead of of_find_node_by_name() Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-18 16:50 +0200
    Re: [PATCH v3 1/8] Input: synaptics-rmi4: Use of_get_child_by_name()  instead of of_find_node_by_name() Andrew Duggan <aduggan@synaptics.com> - 2016-07-19 01:20 +0200
      Re: [PATCH v3 1/8] Input: synaptics-rmi4: Use of_get_child_by_name()  instead of of_find_node_by_name() Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-19 11:40 +0200

csiph-web