Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter page_mask usage

From	Chen Gang <chengang@emindsoft.com.cn>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter page_mask usage
Date	2016-07-12 19:10 +0200
Message-ID	<rU9m2-7TC-25@gated-at.bofh.it> (permalink)
References	<rT4eK-5W3-7@gated-at.bofh.it> <rTQMp-41w-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 7/12/16 05:17, Andrew Morton wrote:
> On Sun, 10 Jul 2016 01:17:05 +0800 chengang@emindsoft.com.cn wrote:
> 
>> For a pure output parameter:
>>
>>  - When callee fails, the caller should not assume the output parameter
>>    is still valid.
>>
>>  - And callee should not assume the pure output parameter must be
>>    provided by caller -- caller has right to pass NULL when caller does
>>    not care about it.
> 
> Sorry, I don't think this one is worth merging really.
> 

OK, thanks, I can understand.

It will be better if provide more details: e.g.

 - This patch is incorrect, or the comments is not correct.

 - The patch is worthless, at present.

 - ...

By the way, this patch let the callee keep the output parameter no touch
if callee no additional outputs, callee assumes caller has initialized
the output parameter (for me, it is OK, there are many cases like this).

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

Thread

Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter  page_mask usage Andrew Morton <akpm@linux-foundation.org> - 2016-07-11 23:20 +0200
  Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter  page_mask usage Chen Gang <chengang@emindsoft.com.cn> - 2016-07-12 19:10 +0200
    Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter  page_mask usage Michal Hocko <mhocko@kernel.org> - 2016-07-13 10:00 +0200
      Re: [PATCH] mm: gup: Re-define follow_page_mask output parameter  page_mask usage Chen Gang <chengang@emindsoft.com.cn> - 2016-07-17 02:20 +0200

csiph-web