Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1441587

Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver

Show all headers | View raw

Am Dienstag, den 12.07.2016, 14:43 +0200 schrieb Daniel Vetter:
> On Tue, Jul 12, 2016 at 01:54:28PM +0200, Lothar Waßmann wrote:
> > Hi,
> > 
> > On Wed, 25 May 2016 15:18:16 +0200 Lothar Waßmann wrote:
> > > The 'de-active' and 'pixelclk-active' DT properties are evaluated
> > > by of_parse_display_timing() called from  of_get_drm_display_mode(),
> > > but later lost in the conversion from videomode.flags to
> > > drm_display_mode.flags.
> > > Use an open coded version of of_get_drm_display_mode() to get access
> > > to these flags and make sure they are passed on to the ipu-di driver.
> > > 
> > > Changes vs. v2:
> > >   - removed patches which have already been applied
> > >   - created a drm_bus_flags_from_videomode() helper to prevent code
> > >     duplication as suggested by Philipp Zabel
> > > 
> > > Changes vs. v1:
> > >   - rebased on top of https://patchwork.kernel.org/patch/9113791/ as
> > >     per Philipp Zabel's request
> > > 
> > > GIT: [PATCHv2 1/3] drm/imx: imx-ldb: honor 'native-mode' property when
> > > GIT: [PATCHv2 2/3] drm/imx: convey the pixelclk-active and de-active flags
> > > GIT: [PATCHv2 3/3] drm/imx: remove dead code
> 
> Should this be split up into 3 patches? At least it's good practice to
> split up the drm core helper functions into it's own patch, instead of
> hiding it behind something with the drm/imx prefix - no one will spot it
> that way.
> 
> > Ping?!
> 
> If imx maintainers keep being asleep at the helm I can merge this through
> drm-misc, but I'd like some more tested-by from other folks if possible.
> Even better when there's a review.

This clashes with the atomic modeset changes. If you don't disagree with
the core change, I can include it with the next imx-drm/next pull
request.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active  flags from DT to the ipu-di driver Lothar Waßmann <LW@KARO-electronics.de> - 2016-07-12 14:00 +0200
  Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active  flags from DT to the ipu-di driver Daniel Vetter <daniel@ffwll.ch> - 2016-07-12 14:50 +0200
    Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active  flags from DT to the ipu-di driver Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-12 19:00 +0200
  Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active  flags from DT to the ipu-di driver Philipp Zabel <p.zabel@pengutronix.de> - 2016-07-12 18:50 +0200

csiph-web