Re: 答复: BUG: INTx is assered unexpectly when unload AHCI driver with MSIx support.

From	"tj@kernel.org" <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: 答复: BUG: INTx is assered unexpectly when unload AHCI driver with MSIx support.
Date	2016-07-12 19:40 +0200
Message-ID	<rU9P4-85j-21@gated-at.bofh.it> (permalink)
References	<rRVwR-1tj-23@gated-at.bofh.it> <rRVwR-1tj-21@gated-at.bofh.it> <rU9P4-85j-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, Jul 11, 2016 at 05:16:00AM +0000, Pang Raymond wrote:
> static irqreturn_t  ahci_multi_irqs_intr_hard(int irq,
> void *dev_instance)
> {
>       //  omitting unconcerned codes here
>       //  ...
>            status = readl(port_mmio + PORT_IRQ_STAT);
>            writel(status, port_mmio + PORT_IRQ_STAT);
> 
>       // add patch code here.
> +         writel(1 << ap->port_no, ap->host->iomap + HOST_IRQ_STAT);
> 
>       // ...

I think it'd be better to avoid adding stuff to the hot path.  This
only matters when the device is shut down, right?  Can't it just be
cleared in the driver cleanup path?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: 答复: BUG: INTx is assered  unexpectly when unload AHCI driver with MSIx support. "tj@kernel.org" <tj@kernel.org> - 2016-07-12 19:40 +0200
  Re: BUG: INTx is assered unexpectly when unload AHCI driver with  MSIx support. "tj@kernel.org" <tj@kernel.org> - 2016-07-19 00:30 +0200

csiph-web