Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors

From	Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors
Date	2016-07-12 18:10 +0200
Message-ID	<rU8pX-7fu-15@gated-at.bofh.it> (permalink)
References	<rTS1Q-4LO-33@gated-at.bofh.it> <rU6xS-5Z5-65@gated-at.bofh.it> <rU7ax-6ed-1@gated-at.bofh.it> <rU8gh-6Wm-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/12/2016 09:51 AM, Joe Perches wrote:
> On Tue, 2016-07-12 at 08:42 -0600, Shuah Khan wrote:
>> On 07/12/2016 08:06 AM, Joe Perches wrote:
>>> On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
>>>> Fix misspelled error message and existing checkpatch errors in the
>>>> error message conditional.
>>> []
>>>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>>> []
>>>> @@ -775,11 +775,11 @@ static int vidioc_g_crop(struct file *file, void *priv,
>>>>  	u32 left, right, top, bottom;
>>>>  
>>>>  	if (ctx->state != MFCINST_HEAD_PARSED &&
>>>> -	ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
>>>> -					&& ctx->state != MFCINST_FINISHED) {
>>>> -			mfc_err("Cannont set crop\n");
>>>> -			return -EINVAL;
>>>> -		}
>>>> +	    ctx->state != MFCINST_RUNNING && ctx->state != MFCINST_FINISHING
>>>> +	    && ctx->state != MFCINST_FINISHED) {
>>>> +		mfc_err("Can not get crop information\n");
>>>> +		return -EINVAL;
>>>> +	}
>>> is it a set or a get?
>> vidioc_g_crop is a get routine.
>>>
>>> It'd be nicer for humans to read if the alignment was consistent
>> Are you okay with this alignment change or would you like it
>> changed?
> 
> Well, if you're resubmitting, I'd prefer it changed.
> Thanks.
> 

chekcpatch stopped complaining. Are you looking for the entire file
alignments changed? I am not clear on what needs to be changed?

thanks,
-- Shuah

Thread

[PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-12 00:40 +0200
  Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Joe Perches <joe@perches.com> - 2016-07-12 16:10 +0200
    Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-12 16:50 +0200
      Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Joe Perches <joe@perches.com> - 2016-07-12 18:00 +0200
        Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-12 18:10 +0200
          Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Joe Perches <joe@perches.com> - 2016-07-12 18:20 +0200
  Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-12 17:10 +0200
  Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Shuah Khan <shuahkh@osg.samsung.com> - 2016-07-12 17:10 +0200
  Re: [PATCH] media: s5p-mfc Fix misspelled error message and  checkpatch errors Javier Martinez Canillas <javier@osg.samsung.com> - 2016-07-12 17:10 +0200

csiph-web